rainbownapkin/canopy
1
0
Fork 0
Code Issues 2 Pull requests Actions Packages Projects Releases Wiki Activity

Traded bug with queue.end() being called as volatile from functions which handle their own DB save, in which stale item was left in cache, for a simple queue rending bug.

Browse source
This commit is contained in:
rainbow napkin 2025-10-25 09:55:40 -04:00
parent f95a0ae48c
commit 37990ff8c3
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/app/channel/media/queue.js
View file

@ -1209,6 +1209,12 @@ class queue{
return this.endLivestream(wasPlaying, chanDB) return this.endLivestream(wasPlaying, chanDB)
} }
//Moved this from the block below to prevent accidental over-caching
//We may need to throw this into it's own conditional if it causes issues
//Take it out of the active schedule
this.schedule.delete(wasPlaying.startTime);
//If we're not in volatile mode and we're not ending a livestream //If we're not in volatile mode and we're not ending a livestream
if(!volatile){ if(!volatile){
//If we wheren't handed a channel //If we wheren't handed a channel
@ -1229,9 +1235,6 @@ class queue{
await chanDB.media.nowPlaying.deleteOne(); await chanDB.media.nowPlaying.deleteOne();
} }
//Take it out of the active schedule
this.schedule.delete(wasPlaying.startTime);
//If archiving is enabled //If archiving is enabled
if(!noArchive){ if(!noArchive){
//Add the item to the channel archive //Add the item to the channel archive