rainbownapkin/canopy
1
0
Fork 0
Code Issues 2 Pull requests Actions Packages Projects Releases Wiki Activity

Official Embed Player #129

New issue
Closed
opened 2025-05-04 23:32:50 -04:00 by rainbownapkin · 6 comments
rainbownapkin commented 2025-05-04 23:32:50 -04:00 (Migrated from gitlab.com)
Copy link

Add support for the official youtube video player, despite how gross it is.

Add support for the official youtube video player, despite how gross it is.
rainbownapkin commented 2025-05-04 23:32:50 -04:00 (Migrated from gitlab.com)
Copy link

added #124 as parent issue

added #124 as parent issue
rainbownapkin commented 2025-05-04 23:33:40 -04:00 (Migrated from gitlab.com)
Copy link

changed the description

changed the description
rainbownapkin (Migrated from gitlab.com) closed this issue 2025-05-07 01:11:15 -04:00
rainbownapkin commented 2025-05-07 01:11:16 -04:00 (Migrated from gitlab.com)
Copy link

Added settings panel to support embed dropdown.

Started work on pulling iframe embed api when dropdown is set to official embed: aadeac03df

Added settings panel to support embed dropdown. Started work on pulling iframe embed api when dropdown is set to official embed: aadeac03dfd99fb7822c2cd8f4ba5c2e15e39c10
rainbownapkin (Migrated from gitlab.com) reopened this issue 2025-05-07 08:17:11 -04:00
rainbownapkin commented 2025-05-07 08:25:31 -04:00 (Migrated from gitlab.com)
Copy link

Started work on implementing iframe embed api: 1344756449

Looks like according to google doc's (not google docs lol), the show_info info flag was deprecated back in 2018.

We'll probably have to make a custom bottom player control set, instead of just the title bar, at some point so we can fully hide all controls to handle this in a nice way.

Plus we could use that for the other handlers to create a more unified UX. Might be worth looking into in the future.

Started work on implementing iframe embed api: 1344756449fe0c47a29cfef97ab040c82daf9b3f Looks like according to google doc's (not google docs lol), the `show_info` info flag was deprecated back in 2018. We'll probably have to make a custom bottom player control set, instead of just the title bar, at some point so we can fully hide all controls to handle this in a nice way. Plus we could use that for the other handlers to create a more unified UX. Might be worth looking into in the future.
rainbownapkin commented 2025-05-08 08:24:42 -04:00 (Migrated from gitlab.com)
Copy link

Finished implementing buildPlayer() function for youtubeEmbedHandler (slow night :P): 1b0caa5e02

Finished implementing buildPlayer() function for youtubeEmbedHandler (slow night :P): 1b0caa5e02cf4c3232e3a87731586a7395b535e0
rainbownapkin commented 2025-05-10 12:29:41 -04:00 (Migrated from gitlab.com)
Copy link

Finished Implementing Official Youtube embedded iframe player support: 473b54356e & e4bebce431

Finished Implementing Official Youtube embedded iframe player support: 473b54356e3749969da9481f2420664230c736c8 & e4bebce431c97dc3229cd10ec99ba2992827b2a9
rainbownapkin (Migrated from gitlab.com) closed this issue 2025-05-10 12:29:45 -04:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
dev
0.4-indev-hotfix-3
0.4-indev-hotfix-2
0.4-indev-hotfix-1
0.4-indev
0.3-indev-hotfix-1
0.3-indev
verbose-queue
0.2-indev
0.1-indev
No results found.
Labels
Clear labels   
Bug

   
Cleanup/Refactor

   
Core Feature

   
Documentation

   
Feature

   
Performance Improvement

   
Security Improvement

   
UX/Accessibility

   
Unreproducable Bug
No labels
Bug
Cleanup/Refactor
Core Feature
Documentation
Feature
Performance Improvement
Security Improvement
UX/Accessibility
Unreproducable Bug
Milestone
Clear milestone
No items
No milestone
Canopy v0.3-Indev
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: rainbownapkin/canopy#129
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?