Handle Queue Items After Livestream #136
Labels
No labels
Bug
Cleanup/Refactor
Core Feature
Documentation
Feature
Performance Improvement
Security Improvement
UX/Accessibility
Unreproducable Bug
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: rainbownapkin/canopy#136
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Properly handle queue items after livestream has ended.
Give the user the option of either over-writing and skipping the items which where scheduled during the stream, or give them the option of pushing everything after the stream.
added #130 as parent issue
changed the description
Noticed a bug to keep an eye on:
When items are queued after stream begins, and the stream ends before said items, it plays those items as expected. However if the stream starts after an items starts, and ends before it ends, the item does not resume as expected.
This is because the refreshNextTimer checks for items in the queue, while items that have actually started playing are moved to nowPlaying.
goLive() manually sets the nowPlaying property of the queue class, and doesn't do anything with the current value, essentially tossing the only RAM copy of the media object.
While this isn't worth fixing before we start work on proper livestream/schedule handling, I should at least make a note to ensure that this is properly handled when this part of the codebase is worked.
mentioned in task #132
As mentioned in #132, we should create a collapsable queue prompt (a-la add media) which allows the user to name their Livestream and choose the scheduling mode (overwrite or pushback).
Livestreams now handle surrounding media properly. OverwriteSchedule DB mode has been completed. Livestreams will gracefully dissapear and fall back on to the standard schedule if the server stops or crashes during a livestream:
8c8b2a6f0bSchedule Pushback mode fore Livestreams complete:
b5e54afe99Looks like there might be weirdness with this left but it's hard to tell. Might be worth keepin' an eye on. All the tests I run now seem good.