rainbownapkin/canopy
1
0
Fork 0
Code Issues 2 Pull requests Actions Packages Projects Releases Wiki Activity

Re-implement functions on certain pages to use DOM dataset. #151

New issue
Closed
opened 2025-05-15 06:55:56 -04:00 by rainbownapkin · 4 comments
rainbownapkin commented 2025-05-15 06:55:56 -04:00 (Migrated from gitlab.com)
Copy link

Some pages use html element's ID to hold data instead of 'data-xxx' attributes.

This is really gross and makes no sense, especially since querySelector(['data-xxx']) should work fine.

Find and fix any functions that do this (looking at you Admin Panel and Channel Settings Page)

Some pages use html element's ID to hold data instead of 'data-xxx' attributes. This is really gross and makes no sense, especially since querySelector(['data-xxx']) should work fine. Find and fix any functions that do this (looking at you Admin Panel and Channel Settings Page)
rainbownapkin commented 2025-05-15 06:55:56 -04:00 (Migrated from gitlab.com)
Copy link

added #137 as parent issue

added #137 as parent issue
rainbownapkin commented 2025-05-15 06:57:29 -04:00 (Migrated from gitlab.com)
Copy link

changed the description

changed the description
rainbownapkin commented 2025-09-07 09:46:00 -04:00 (Migrated from gitlab.com)
Copy link

Re-implemented adminPanel.js to use DOM-dataset over ID Splicing: 3ab6c6c715

Re-implemented adminPanel.js to use DOM-dataset over ID Splicing: 3ab6c6c7152e874287b43240d932f28215e1d336
rainbownapkin (Migrated from gitlab.com) closed this issue 2025-09-08 07:35:57 -04:00
rainbownapkin commented 2025-09-08 07:35:58 -04:00 (Migrated from gitlab.com)
Copy link

Re-implemented channel settings panel to use DOM-dataset over ID splicing: 92659929b9

Doesn't seem like any other big pages have this issue. If we see it going forward, it's at least pretty ezpz to correct.

Re-implemented channel settings panel to use DOM-dataset over ID splicing: 92659929b95178196bfcff8d1b759f0cb5f7b9c1 Doesn't seem like any other big pages have this issue. If we see it going forward, it's at least pretty ezpz to correct.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
dev
0.4-indev-hotfix-3
0.4-indev-hotfix-2
0.4-indev-hotfix-1
0.4-indev
0.3-indev-hotfix-1
0.3-indev
verbose-queue
0.2-indev
0.1-indev
No results found.
Labels
Clear labels   
Bug

   
Cleanup/Refactor

   
Core Feature

   
Documentation

   
Feature

   
Performance Improvement

   
Security Improvement

   
UX/Accessibility

   
Unreproducable Bug
No labels
Bug
Cleanup/Refactor
Core Feature
Documentation
Feature
Performance Improvement
Security Improvement
UX/Accessibility
Unreproducable Bug
Milestone
Clear milestone
No items
No milestone
Canopy v0.3-Indev
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: rainbownapkin/canopy#151
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?