rainbownapkin/canopy
1
0
Fork 0
Code Issues 2 Pull requests Actions Packages Projects Releases Wiki Activity

Replace all window.alert()/window.prompt() calls with canopyUXUtils.popup() #53

New issue
Closed
opened 2024-11-29 13:02:15 -05:00 by rainbownapkin · 2 comments
rainbownapkin commented 2024-11-29 13:02:15 -05:00 (Migrated from gitlab.com)
Copy link

Replace basic built-in browser prompts with custom canopyUXUtils.popup() that allows us to use custom markup and CSS within the dialogue.

These calls where added before canopyUXUtils.popup() was written.

This is a security improvement in the case of popups that take in passwords (such as when deleting your account), as we'd be able to obscure them.

Replace basic built-in browser prompts with custom canopyUXUtils.popup() that allows us to use custom markup and CSS within the dialogue. These calls where added before canopyUXUtils.popup() was written. This is a security improvement in the case of popups that take in passwords (such as when deleting your account), as we'd be able to obscure them.
rainbownapkin commented 2024-11-29 13:02:53 -05:00 (Migrated from gitlab.com)
Copy link

changed the description

changed the description
rainbownapkin commented 2024-12-05 03:50:24 -05:00 (Migrated from gitlab.com)
Copy link

Replaced all window.prompt() and window.alert() calls with new canopyUXUtils.popup()'s: ee5a8d9516

Replaced all window.prompt() and window.alert() calls with new canopyUXUtils.popup()'s: ee5a8d95165dc19b07349197e22b3d1e57e910da
rainbownapkin (Migrated from gitlab.com) closed this issue 2024-12-05 03:50:25 -05:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
dev
0.4-indev-hotfix-3
0.4-indev-hotfix-2
0.4-indev-hotfix-1
0.4-indev
0.3-indev-hotfix-1
0.3-indev
verbose-queue
0.2-indev
0.1-indev
No results found.
Labels
Clear labels   
Bug

   
Cleanup/Refactor

   
Core Feature

   
Documentation

   
Feature

   
Performance Improvement

   
Security Improvement

   
UX/Accessibility

   
Unreproducable Bug
No labels
Bug
Cleanup/Refactor
Core Feature
Documentation
Feature
Performance Improvement
Security Improvement
UX/Accessibility
Unreproducable Bug
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: rainbownapkin/canopy#53
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?