fore.st/src/channel
Calvin Montgomery c152a19624 Ignore library cached metadata when queueing
The use of the channel library as a cache for metadata to avoid
re-requesting metadata for known media is an optimization that dates
back to 1.0.  However, it doesn't have any TTL, is prone to bugs, and is
of dubious value.

This commit ignores the results of the library check when queueing a new
video, opting to always re-request the metadata.  This fixes a few bugs:

  * Google Drive metadata being lost when storing in library
  * Streamable metadata being lost when storing in library
  * Videos in the channel library that are now unavailable on their
    source website being queueable and then failing to play (e.g. deleted
    YouTube videos).

In its place, a small fail-open check is left behind to emit metric
counters on how many queues would have been cache-hits, to provide
insight into whether a proper caching solution (i.e. one not tacked on
top of the library) would be worth pursuing or not.  This will be
removed eventually.
2017-07-15 14:41:37 -07:00
..
accesscontrol.js Purge the awful refreshAccount logic 2016-10-03 23:12:22 -07:00
channel.js Upgrade to jsli 2.0 2017-07-08 20:11:54 -07:00
chat.js Send shadowmuted messages to anons 2017-06-20 22:29:27 -07:00
customization.js package: build with babel for ES2015 support 2015-09-23 19:27:04 -07:00
drink.js package: build with babel for ES2015 support 2015-09-23 19:27:04 -07:00
emotes.js Some validation 2017-05-18 20:12:00 -07:00
filters.js Upgrade to jsli 2.0 2017-07-08 20:11:54 -07:00
kickban.js Fix user join ban check for users with blank names (but clean IPs) 2017-03-15 23:44:03 -07:00
library.js Replace old ActiveLock system with a slightly better one 2015-12-25 17:07:25 -08:00
mediarefresher.js Upgrade to jsli 2.0 2017-07-08 20:11:54 -07:00
module.js package: build with babel for ES2015 support 2015-09-23 19:27:04 -07:00
opts.js Fix setOptions for playlist_max_duration_per_user 2017-05-20 16:31:52 -07:00
permissions.js Implement max total video time per user 2017-04-03 21:18:40 -07:00
playlist.js Ignore library cached metadata when queueing 2017-07-15 14:41:37 -07:00
poll.js Handle the case where no socket.io ack exists 2017-03-20 22:09:16 -07:00
ranks.js Resend userlist if rank changes meta visibility 2017-06-17 09:47:22 -07:00
voteskip.js Fix voteskip issue when there are no videos left 2017-03-21 20:04:06 -07:00