rainbownapkin/canopy
1
0
Fork 0
Code Issues 2 Pull requests Actions Packages Projects Releases Wiki Activity

Serverside Media Check #32

New issue
Closed
opened 2024-11-15 18:18:21 -05:00 by rainbownapkin · 4 comments
rainbownapkin commented 2024-11-15 18:18:21 -05:00 (Migrated from gitlab.com)
Copy link
No description provided.
rainbownapkin commented 2024-11-15 18:18:21 -05:00 (Migrated from gitlab.com)
Copy link

added #30 as parent issue

added #30 as parent issue
rainbownapkin commented 2024-12-03 07:28:01 -05:00 (Migrated from gitlab.com)
Copy link

Looks like the best way to implement embedded media checks for chat is to send a HEAD request to get file size, and npm module 'file-type' for file-type checking. (not big on adding modules, but it's best to use battle-tested security/validation code.)

Looks like the best way to implement embedded media checks for chat is to send a HEAD request to get file size, and npm module 'file-type' for file-type checking. (not big on adding modules, but it's best to use battle-tested security/validation code.)
rainbownapkin commented 2024-12-16 06:59:36 -05:00 (Migrated from gitlab.com)
Copy link

Downloading and checking with file-type seems excessive and will cause performance issues.

If lying servers become an issue in the future we can rectify it then.

Downloading and checking with file-type seems excessive and will cause performance issues. If lying servers become an issue in the future we can rectify it then.
rainbownapkin (Migrated from gitlab.com) closed this issue 2024-12-16 09:02:44 -05:00
rainbownapkin commented 2024-12-16 09:02:45 -05:00 (Migrated from gitlab.com)
Copy link

Serverside media check added: 23df4f88f9

Serverside media check added: 23df4f88f92741d4a968471b2db90c6d536d17dc
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
dev
0.4-indev-hotfix-3
0.4-indev-hotfix-2
0.4-indev-hotfix-1
0.4-indev
0.3-indev-hotfix-1
0.3-indev
verbose-queue
0.2-indev
0.1-indev
No results found.
Labels
Clear labels   
Bug

   
Cleanup/Refactor

   
Core Feature

   
Documentation

   
Feature

   
Performance Improvement

   
Security Improvement

   
UX/Accessibility

   
Unreproducable Bug
No labels
Bug
Cleanup/Refactor
Core Feature
Documentation
Feature
Performance Improvement
Security Improvement
UX/Accessibility
Unreproducable Bug
Milestone
Clear milestone
No items
No milestone
Canopy v0.1-Indev
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: rainbownapkin/canopy#32
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?